Update mypy, fix its configuration #204
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run mypy from the local venv, not via pre-commit, so that it has access to all the dependencies. Always typecheck the entire repo, not individual files.
danielhollas
commented
Dec 8, 2025
| of packed objects, and the number of pack files.""" | ||
|
|
||
| # TODO: Remove type: ignore! Do we need to handle number_packed==None? | ||
| number_packed = self._get_operation_session().scalar(select(func.count()).select_from(Obj)) |
Contributor
Author
There was a problem hiding this comment.
mypy thinks number_packed can be None. I am not sure if it is correct or not.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 8 8
Lines 1931 1931
=======================================
Hits 1924 1924
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
mypy-update
branch
from
9937f84 to
1a12af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is not how we do this in aiida-core where things are complicated since we're ignoring files from type-checking)
TODO
I needed to add a bunch of
type: ignores. Please see comments inline. These should probably be fixed properly