Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ENVIRON namelists #703

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a991ec6
Added boundary and electrostatic namelists for ENVIRON
Jun 5, 2021
d2691b8
Added example environ calculation for testing purposes
Jun 5, 2021
a134570
Merge branch 'aiidateam:develop' into develop
sudarshanv01 Jul 11, 2021
d753459
Added test for generating Environ namelist
Jul 11, 2021
726b355
Added some documentation about how to run Environ and some enabled pa…
Jul 11, 2021
64161bc
Fixed typo in parsing of Environ
Jul 15, 2021
12be851
Merge branch 'develop' into develop
mbercx Jul 22, 2021
9fc3a1a
Added tests to pw parser and calculation and added log to exception o…
Jul 23, 2021
b5d2859
Merge branch 'develop' of git+ssh://github.com/sudarshanv01/aiida-qua…
Jul 23, 2021
29e0574
Merge branch 'develop' of git+ssh://github.com/sudarshanv01/aiida-qua…
Jul 23, 2021
894b95a
Merge branch 'develop' of git+ssh://github.com/sudarshanv01/aiida-qua…
Jul 23, 2021
e38ddf1
Merge branch 'develop' of github.com:sudarshanv01/aiida-quantumespres…
Aug 7, 2021
8f0bb86
Make environ tests work in both calculations and parser
Aug 7, 2021
1f6dd1b
Changes from pre-commit to Environ test
Aug 7, 2021
db7d722
Changes from pre-commit to Environ test
Aug 7, 2021
f657f45
Added parser test, calculation files for Environ
Nov 21, 2021
9ef55c5
Added parser test, calculation files for Environ
Nov 21, 2021
4168fee
Added parser test, calculation files for Environ
Nov 21, 2021
5009842
Run environ calculation parser only if it is an environ calculation.
Nov 22, 2021
3d13abb
Merge environ namelists test into one
Nov 22, 2021
90aae90
Fixed is_environ tag
Nov 22, 2021
acb2d0a
Update docs/source/user_guide/get_started/examples/pw_tutorial.rst
sudarshanv01 Nov 23, 2021
c8016b8
Update tests/conftest.py
sudarshanv01 Nov 23, 2021
fe50cfa
Update tests/conftest.py
sudarshanv01 Nov 23, 2021
5764e4f
Update tests/parsers/test_pw.py
sudarshanv01 Nov 23, 2021
ed7e70c
Update tests/calculations/test_pw.py
sudarshanv01 Nov 23, 2021
94d1e85
Update tests/parsers/test_pw.py
sudarshanv01 Nov 23, 2021
2e5bc1b
Removed Pt structure from conftest
Nov 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added boundary and electrostatic namelists for ENVIRON
  • Loading branch information
Sudarshan committed Jun 5, 2021
commit a991ec6c8fbe6524f2d5094625908f90eb3bdc2c
17 changes: 17 additions & 0 deletions aiida_quantumespresso/calculations/__init__.py
Original file line number Diff line number Diff line change
@@ -238,6 +238,11 @@ def prepare_for_submission(self, folder):
if environ_namelist is not None:
if not isinstance(environ_namelist, dict):
raise exceptions.InputValidationError('ENVIRON namelist should be specified as a dictionary')

## Check for BOUNDARY and ELECTROSTATIC Keys as well
boundary_namelist = settings.pop('BOUNDARY', None)
electrostatic_namelist = settings.pop('ELECTROSTATIC', None)

# We first add the environ flag to the command-line options (if not already present)
try:
if '-environ' not in settings['CMDLINE']:
@@ -255,6 +260,18 @@ def prepare_for_submission(self, folder):
handle.write(convert_input_to_namelist_entry(key, value, mapping=mapping_species))
handle.write('/\n')

if boundary_namelist is not None:
handle.write('&BOUNDARY\n')
for key, value in sorted(boundary_namelist.items()):
handle.write(convert_input_to_namelist_entry(key, value, mapping=mapping_species))
handle.write('/\n')

if electrostatic_namelist is not None:
handle.write('&ELECTROSTATIC\n')
for key, value in sorted(electrostatic_namelist.items()):
handle.write(convert_input_to_namelist_entry(key, value, mapping=mapping_species))
handle.write('/\n')

# Check for the deprecated 'ALSO_BANDS' setting and if present fire a deprecation log message
also_bands = settings.pop('ALSO_BANDS', None)
if also_bands: