Skip to content

Conversation

yrkim98
Copy link
Collaborator

@yrkim98 yrkim98 commented Sep 15, 2025

Big update to update fua to use FSS v4.

Main thing changed is removing anything to do with chunked uploads, using fssv4's new upload endpoint instead.

Most important files to look at are the following:

src/renderer/services/file-management-system/index.ts: contains the bulk of the changes needed to match FUA up with FSS v4. Mainly removing old v3 methods (register, finalize) and chunked uploads and replacing them with new v4 upload method. Also some changes to retry and cancel which were simplified in FSS v4.
src/renderer/services/file-storage-service/index.ts: same thing

src/renderer/containers/App/handleUploadJobUpdates.ts: handles progress updates as upload progresses

src/main/index.ts: changed to re-enable react dev tools with a stackoverflow post i found
package.json: changed to re-enable react dev tools with a stackoverflow post i found
package-lock.json: added concurrently and wait-on which added a bunch of deps, is this normal for npm?

the rest of the files is updating tests to v4 or removing tests that test for old v3 patterns.

note: I was trying vscode's source control for the first time and thought i was committing small chunks of this but ig I was not and everything was squashed into one commit at the end

Copy link
Contributor

@hughes036 hughes036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big simplification!

  • Have you done sufficient manual testing in stg, and seen uploads uploads and status updates work?
  • I see a lot of deleted tests from the filemanagementsystem suite - do we still have good coverage on the V4 public methods?

Copy link

@saeliddp saeliddp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! A few questions

@hughes036
Copy link
Contributor

@saeliddp We wont have this situation, but from an engineering pov, how someone writing a new query find out what version to use for each resource? My sense is that we should just roll fwd the whole API version (even resources that have not changed), and document what our current version is on the FSS readme.

Thoughts?

@yrkim98
Copy link
Collaborator Author

yrkim98 commented Sep 18, 2025

Big simplification!

  • Have you done sufficient manual testing in stg, and seen uploads uploads and status updates work?
  • I see a lot of deleted tests from the filemanagementsystem suite - do we still have good coverage on the V4 public methods?

I have tested against staging and uploads and status updates work

All deleted tests have to do with old v3 patterns such as file chunking, etc. If they were still relevant to v4 they were updated instead and some tests were added for methods I created for v4

@yrkim98
Copy link
Collaborator Author

yrkim98 commented Sep 18, 2025

doing some add'l testing after these updates

@saeliddp
Copy link

saeliddp commented Sep 19, 2025

@saeliddp We wont have this situation, but from an engineering pov, how someone writing a new query find out what version to use for each resource? My sense is that we should just roll fwd the whole API version (even resources that have not changed), and document what our current version is on the FSS readme.

Thoughts?

I don't have a strong opinion, so I'm good with your suggestion. My original rationale was that since only the upload endpoints were changing, only those endpoints would need an API version bump. If we want to put all controllers/resources under the same API version umbrella, then we should see if we can refactor the FSS code to make that clearer (right now, each controller defines its own API version prefix).

Edit: I do think this should come as a later change though--I want to prioritize getting V4 FUA out first.

Copy link

@saeliddp saeliddp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've manually tested all combinations of singlefile/multifile, cloud-only/hybrid, then it seems good to go!

@yrkim98
Copy link
Collaborator Author

yrkim98 commented Sep 22, 2025

Assuming you've manually tested all combinations of singlefile/multifile, cloud-only/hybrid, then it seems good to go!

This was all tested, can confirm everything working as expected. merging!

@yrkim98 yrkim98 merged commit 4d4e113 into main Sep 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants