Skip forbidden resources as they are rarely required #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is agreeable, there's just a little bug that we need to assign to |
Signed-off-by: Ahmet Alp Balkan <[email protected]>
Signed-off-by: Ahmet Alp Balkan <[email protected]>
Signed-off-by: Ahmet Alp Balkan <[email protected]>
|
Any updates on that? |
|
+1, would be nice to see this merged. |
|
+1 waiting for it |
ahmetb
approved these changes
Jul 1, 2024
.github/workflows/ci.yml
Outdated
| @@ -11,7 +11,7 @@ jobs: | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v1 | |||
| with: | |||
| go-version: 1.18 | |||
| go-version: 1.20 | |||
There was a problem hiding this comment.
You need to type ' or " around this otherwise it becomes 1.2 float :) at this point let's do 1.22
There was a problem hiding this comment.
Omg i made this error myself it turns out 🤦
|
+1, would be nice to see this merged. |
|
sorry for the delay - missed this. hows this look? |
|
+1 |
ahmetb
approved these changes
Nov 23, 2024
|
it seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi-tenant cluster, rarely do users have permissions to view all API resources. This makes it so any resource that is forbidden to the user will be skipped.
Fixes #14
Fixes #60