Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change api url #9

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Change api url #9

wants to merge 9 commits into from

Conversation

Fortich
Copy link

@Fortich Fortich commented Apr 28, 2018

No description provided.

ahmetabdi and others added 9 commits April 2, 2017 23:54
- Updated auth headers for Mashape.
- Added 'fields' to default query string.

- Refactored models and representers.
- Deleted deprecated models and representers.

- Created missing models and representers.

- Added base representer for common fields.

- Started implementation of new representers

- Moved api methods out of models and into api_resource.
- Changed the meta method to 'count'.

- Updated tests.
- Updated gems.

- Bump version

- Use included hook in BaseRepresenter to DRY up representers.

- Clean up specs. Move some strings into RSpec config. Minor changes to try and make houndci happy.
property :width
property :height
property :id
end
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingBlankLines: Final newline missing.

@@ -1,9 +1,8 @@
module Igdb::GameScreenshotRepresenter
module Igdb::ImageRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.

include Igdb::BaseRepresenter

collection :games
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingBlankLines: Final newline missing.

@@ -0,0 +1,5 @@
module Igdb::KeywordRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.

@@ -0,0 +1,5 @@
module Igdb::GenreRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.

include Igdb::BaseRepresenter

collection :games
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingBlankLines: Final newline missing.

@@ -0,0 +1,5 @@
module Igdb::FranchiseRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.

include Igdb::BaseRepresenter

collection :games
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingBlankLines: Final newline missing.

@@ -0,0 +1,5 @@
module Igdb::GameModeRepresenter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.

property :average_rating # The average rating of all the games the company that has developed or published.
property :parent # The id of the parent company.
property :size # The number of companies in the database.
property :logo, extend: Igdb::ImageRepresenter, class: OpenStruct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants