-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change api url #9
base: master
Are you sure you want to change the base?
Conversation
- Updated auth headers for Mashape. - Added 'fields' to default query string. - Refactored models and representers. - Deleted deprecated models and representers. - Created missing models and representers. - Added base representer for common fields. - Started implementation of new representers - Moved api methods out of models and into api_resource. - Changed the meta method to 'count'. - Updated tests. - Updated gems. - Bump version - Use included hook in BaseRepresenter to DRY up representers. - Clean up specs. Move some strings into RSpec config. Minor changes to try and make houndci happy.
property :width | ||
property :height | ||
property :id | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/TrailingBlankLines: Final newline missing.
@@ -1,9 +1,8 @@ | |||
module Igdb::GameScreenshotRepresenter | |||
module Igdb::ImageRepresenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
include Igdb::BaseRepresenter | ||
|
||
collection :games | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/TrailingBlankLines: Final newline missing.
@@ -0,0 +1,5 @@ | |||
module Igdb::KeywordRepresenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
@@ -0,0 +1,5 @@ | |||
module Igdb::GenreRepresenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
include Igdb::BaseRepresenter | ||
|
||
collection :games | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/TrailingBlankLines: Final newline missing.
@@ -0,0 +1,5 @@ | |||
module Igdb::FranchiseRepresenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
include Igdb::BaseRepresenter | ||
|
||
collection :games | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/TrailingBlankLines: Final newline missing.
@@ -0,0 +1,5 @@ | |||
module Igdb::GameModeRepresenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
property :average_rating # The average rating of all the games the company that has developed or published. | ||
property :parent # The id of the parent company. | ||
property :size # The number of companies in the database. | ||
property :logo, extend: Igdb::ImageRepresenter, class: OpenStruct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/TrailingWhitespace: Trailing whitespace detected.
No description provided.