Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cooldown_period to OrTrigger #1004

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

HomerusJa
Copy link

@HomerusJa HomerusJa commented Dec 21, 2024

Changes

Fixes #453

  • Added the cooldown_period attribute to the OrTrigger, preventing two triggers triggering within that interval.
  • Added a max_iterations attribute to the OrTrigger as in the AndTrigger preventing near infinite looping when two triggers are triggering a lot whilst being in the cooldown phase.
  • Added tests to confirm the behavior

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #999, the entry should look like this:

* Fix big bad boo-boo in the async scheduler (#999 <https://github.com/agronholm/apscheduler/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@coveralls
Copy link

coveralls commented Dec 21, 2024

Coverage Status

coverage: 92.039% (+0.006%) from 92.033%
when pulling 5f504e4 on HomerusJa:ortrigger-cooldown
into 844dc05 on agronholm:master.

@HomerusJa
Copy link
Author

Should I add something to the docs? I suppose the API documentation is automatically generated, so where else should I mention this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having the threshold also on OrTrigger?
2 participants