Skip to content

feat(bip39): let mnemonic tools select a language - #58

Merged
oritwoen merged 1 commit into
mainfrom
feat/localized-mnemonics
Sep 9, 2026
Merged

feat(bip39): let mnemonic tools select a language#58
oritwoen merged 1 commit into
mainfrom
feat/localized-mnemonics

Conversation

@aeitwoen

@aeitwoen aeitwoen commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

The BIP39 tools recognize Spanish words but label a valid Spanish mnemonic invalid, an unnecessary dead end. Generation, inspection and entropy encoding now accept an explicit language across all ten lists; English stays the default.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner September 9, 2026 16:56
@aeitwoen aeitwoen self-assigned this Sep 9, 2026
@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 9, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~4 changed · 🔴 -0 removed · 1 flow · 7 files · commit c6fd815


Architecture

Architecture diagram for agntn/keys at c6fd815

4 components touched across 6 lanes.

Open the interactive canvas


Inside the changed components — 2 views

Component view — Tool interfaces & dispatcher

MCP server and Pi extension schemas routing localized mnemonic operations through the dispatcher

Architecture view of Component view — Tool interfaces & dispatcher in agntn/keys

Component view — BIP39 wordlist loader & derivation

Dynamic loading of official BIP39 wordlists and localized mnemonic validation

Architecture view of Component view — BIP39 wordlist loader & derivation in agntn/keys

Data flow

Data flow diagram for agntn/keys at c6fd815

Inspecting a localized BIP39 mnemonic

Open the interactive canvas


Drill down
Client Interfaces — 2 components
🟡 CHANGED MCP Server

Exposes MCP tools over stdio with optional BIP39 language selection.

🟡 CHANGED Pi Coding Agent Extension

Integrates key and mnemonic tools with the Pi coding agent interface.

Tool Operations — 1 component
🟡 CHANGED Tool Operations Dispatcher

Dispatches CLI, MCP, and Pi operations for keys and localized BIP39 mnemonics.

Derivation & Mnemonics — 1 component
🟡 CHANGED BIP39 Mnemonic Engine

Loads official wordlists on demand and handles BIP39 mnemonic encode and decode.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it on an interactive canvas, where you can zoom, pan and step through the flow.
  • The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.
  • Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Come say hi on Discord

@oritwoen
oritwoen merged commit fd10556 into main Sep 9, 2026
3 checks passed
@oritwoen
oritwoen deleted the feat/localized-mnemonics branch September 9, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants