Skip to content

fix(http): stop automatic retries on payload requests - #97

Merged
oritwoen merged 1 commit into
mainfrom
fix/non-idempotent-retries
Sep 11, 2026
Merged

oritwoen merged 1 commit into
mainfrom
fix/non-idempotent-retries

Conversation

@oritwoen

Copy link
Copy Markdown
Member

createHttpClient() replayed POST, PATCH, PUT and DELETE after transient failures. That is dangerous for issue, PR and review reply creation because the first request may already have landed. Write retries are explicit now while ordinary reads keep two retries.

@oritwoen oritwoen self-assigned this Sep 11, 2026
@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 11, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 1 flow · 1 file · commit fa437cc


Architecture

Architecture diagram for agntn/forges at fa437cc

1 component touched across 2 lanes.

Open the interactive canvas


Data flow

Data flow diagram for agntn/forges at fa437cc

Handling request retries

Open the interactive canvas


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works.

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists.
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds.
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through.
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change.
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time.
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time.
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs on every push.
  • Push a commit and the comment redraws for the new head. A slow older run never overwrites a newer one.
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion.

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@oritwoen
oritwoen merged commit 99095d6 into main Sep 11, 2026
2 checks passed
@oritwoen
oritwoen deleted the fix/non-idempotent-retries branch September 11, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant