-
Notifications
You must be signed in to change notification settings - Fork 29
feat(cli): dirctl validate #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).
|
ba4767f to
08cbe01
Compare
|
We should reconsider flag usage, for example:
i think following default + enable approach is more intuitive than enforcing certain checks which need to be explicitly disabled |
|
i dont think we need to have |
These flags are mirroring the available settings for the directory: And the default validation mode is the API validation, that is why if neither of these settings are provided, both dir and this command returns an error that it needs an OASF URL, or the API validator to be disabled. |
6a832f8 to
78db38d
Compare
08cbe01 to
2ca5f1e
Compare
I agree that it has its limits if we are talking about a directory instance with hundreds of thousands of records... my goal with Another idea could be for the Or instead of a path, it could expect the json data directly, so it could be piped into it either from a local file, or the output of a |
2ca5f1e to
4948b0b
Compare
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
4948b0b to
67e6b82
Compare
Signed-off-by: András Jáky <[email protected]>
|
@ramizpolic I removed the |
Signed-off-by: András Jáky <[email protected]>
42417b5 to
c998664
Compare
This PR adds
validatecommand to dirctl to either validate a local json file, or the whole content of the directory with different settings. Latter is done in batches, a test I ran that validated 3214 records finished in 10:17 mins.Closes #767