Fix multiple issues with converting type hints to JSON Schema #2379
+16
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes:
The main problem: newish syntax for unions with
|
supported by Python 3.10 are of typetypes.UnionType
, and didn't matchUnion
. There's a very recently completed issue on CPython that will unify both (apparently for 3.14). See also this MyPy warning about evaluating type hints.Other problems:
isinstance(arg_json_schema["type"], list)
);The code is now simplified while handling new type annotation syntax and null/optional values.
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.sh
and./scripts/validate.sh
to ensure code is formatted and linted.Additional Notes
Linked in the description.