workspace-settings-update-ag-2863 #2377
Open
+83
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbrnd
reviewed
Mar 12, 2025
ashpreetbedi
approved these changes
Mar 12, 2025
Comment on lines
+71
to
+74
| # Public subnets. 1 in each AZ. | ||
| aws_public_subnets: List[str] = Field(default_factory=list) | ||
| # Private subnets. 1 in each AZ. | ||
| aws_private_subnets: List[str] = Field(default_factory=list) |
There was a problem hiding this comment.
do we need the public/private subnets?
|
|
||
| ws_name = info.data.get("ws_name") | ||
| if ws_name is None: | ||
| raise ValueError("ws_name invalid") |
There was a problem hiding this comment.
@ysolanky lets do: ``ws_name is None: Please set a valid value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).