Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID incorrect on model logging #2348

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix ID incorrect on model logging #2348

merged 1 commit into from
Mar 10, 2025

Conversation

dirkbrnd
Copy link
Contributor

Description

Fixes issue where debug logs would be showing the "default" model ID instead of the set model ID, which confuses users.

Fixes #2343

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update (Addition or modification of models)
  • Other (please describe):

Checklist

  • Adherence to standards: Code complies with Agno’s style guidelines and best practices.
  • Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
  • Self-review completed: A thorough review has been performed by the contributor(s).
  • Documentation: Docstrings and comments have been added or updated for any complex logic.
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
  • Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
  • Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).

@dirkbrnd dirkbrnd requested a review from a team as a code owner March 10, 2025 10:40
@manthanguptaa
Copy link
Contributor

I think this should be on the name param instead of provider. Provider will be the name of the model and name can be provider + id. What do you think?

@dirkbrnd dirkbrnd merged commit 1e90b2f into main Mar 10, 2025
2 checks passed
@dirkbrnd dirkbrnd deleted the fix-model-id-logging branch March 10, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Agent Model Mismatch in Agno
3 participants