Whatsapp integration #2335
Open
Whatsapp integration #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbrnd
reviewed
Mar 10, 2025
libs/agno/agno/tools/whatsapp.py
Outdated
Comment on lines
55
to
56
| self.register(self.send_text_message_sync) | ||
| self.register(self.send_template_message_sync) |
There was a problem hiding this comment.
What about async? Maybe have a async_mode:bool attribute at the top? We don't really build async endpoints yet, but that could be a good pattern
libs/agno/agno/tools/whatsapp.py
Outdated
| response.raise_for_status() | ||
| return response.json() | ||
|
|
||
| def send_text_message_sync(self, recipient: Optional[str] = None, text: str = "", preview_url: bool = False) -> str: |
There was a problem hiding this comment.
I would make text the first attribute
Dariton4000
approved these changes
Mar 10, 2025
- Clarify ngrok setup instructions as development testing only - Add missing environment variable for WhatsApp recipient phone number - Regenerate requirements.txt with updated dependencies - Minor formatting and clarity improvements in documentation
…ok domain details - Change environment configuration from `.env` to `.envrc` for better environment variable management - Add instructions for using a static ngrok domain - Remove duplicate `WHATSAPP_WEBHOOK_URL` environment variable - Improve documentation clarity for webhook and ngrok setup
- Remove verbose logging in webhook verification and server startup - Remove dotenv loading from WhatsApp tools - Minor formatting improvements in README and code
- Correct duplicate environment variable checks for access token, phone number ID, recipient, and version - Ensure consistent fallback to specific WhatsApp-prefixed environment variables
- Rename `whatsapp_chat_agent.py` to `app.py` - Update README to reflect the new script name in startup instructions
- Swap order of `recipient` and `text` parameters for better readability - Update method docstring to match new parameter order
- Enhance debugging by logging request and response details - Log URL, headers, request data, status code, response headers, and response body - Use json.dumps for better readability of logged data
- Introduce `async_mode` parameter to enable async message sending methods - Implement `send_text_message_async` and `send_template_message_async` methods - Update toolkit initialization to conditionally register sync or async methods - Enhance configuration logging to include async mode status
dirkbrnd
reviewed
Mar 11, 2025
dirkbrnd
approved these changes
Mar 11, 2025
dirkbrnd
reviewed
Mar 11, 2025
| name="whatsapp", | ||
| tools=[WhatsAppTools()], | ||
| ) | ||
|
|
There was a problem hiding this comment.
Add a simple chat example as well?
- Replaced YFinanceTools with DuckDuckGoTools for improved search capabilities. - Updated agent description to reflect the new functionality and interaction style. - Removed duplicate webhook URL export from README for clarity.
- Revised README to reflect the new AI agent functionality and improved setup instructions. - Added detailed steps for obtaining WhatsApp credentials and configuring the environment. - Enhanced error handling and troubleshooting sections for better user guidance. - Updated `whatsapp_tools.py` to include links for easier navigation and clarified environment variable setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).