Create new merged Storage #2294
Open
+6,788
−3,122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/agno-agi/agno into merge-agentstorage-and-workflowsstorage-ag-2781
…entstorage-and-workflowsstorage-ag-2781
There was a problem hiding this comment.
Should this file be included?
| @@ -1756,7 +1764,7 @@ def read_from_storage(self) -> Optional[AgentSession]: | |||
| Optional[AgentSession]: The loaded AgentSession or None if not found. | |||
| """ | |||
| if self.storage is not None and self.session_id is not None: | |||
| self.agent_session = self.storage.read(session_id=self.session_id) | |||
| self.agent_session = cast(AgentSession, self.storage.read(session_id=self.session_id)) | |||
There was a problem hiding this comment.
Does a type hint like
self.agent_session: AgentSession = .. do the same thing here as casting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are merging AgentStorage and WorkflowStorage. This is to make room for TeamStorage and to provide better feature coverage for workflows.
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).