fix(gate): failed FULL acceptance gate is terminal regardless of noE2eAcceptance (P0a) - #205
Merged
Merged
Conversation
…E2eAcceptance (P0a) Observable-gates plan P0a (4-model panel, unanimous). runFinalAcceptance downgraded a FAILED full gate (validate/build/size/root-drift) to a green 'done' whenever TSFORGE_NO_E2E_ACCEPTANCE was set — the flag was meant to skip only the browser/chain e2e, but the terminal-status guard `!finalPassed && !e2eAcceptanceDisabled` also made the full gate ADVISORY. That is active gate-relaxation and a #204-class false-green (a real red shipped as done). finalPassed is false only when (a) the full gate failed or (b) the browser chain failed; (b) can't occur when the flag is set (the chain is skipped), so when disabled the only way to !finalPassed is a genuine full-gate red — which must be terminal. Drop the `&& !e2eAcceptanceDisabled` guard: a failed final acceptance is ALWAYS stuck. The flag still skips only the chain-acceptance block. Inverted the test that codified the bug (old 'FIX 5': disabled preserves done on gate fail) into two: disabled + full-gate-fail → stuck; disabled + full-gate-pass → done with the chain skipped. Full suite 3140/0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observable-gates plan, P0a (4-model panel, unanimous — the first of the false-green-hardening series).
runFinalAcceptancedowngraded a failed full gate (validate/build/size/root-drift) to a greendonewheneverTSFORGE_NO_E2E_ACCEPTANCEwas set. The flag is meant to skip only the browser/chain e2e, but the terminal-status guard!finalPassed && !e2eAcceptanceDisabledalso made the full gate advisory — active gate-relaxation and a #204-class false-green (a real red shipped asdone).Fix: drop the
&& !e2eAcceptanceDisabledguard.finalPassedis false only when the full gate failed or the browser chain failed; the chain can't run when the flag is set, so a falsefinalPassedunder the flag is always a genuine full-gate red — which must be terminal. The flag still skips only the chain-acceptance block.Inverted the test that codified the bug (old
FIX 5) into two: disabled + full-gate-fail →stuck; disabled + full-gate-pass →done(chain skipped). Full suite 3140/0; typecheck + lint clean. Gate-preserving (additive: turns a swallowed red back into a red).