Changed toString() to Object.prototype.toString() #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strangely enough, the .toString() method fires an error in nodejs when the value comes directly from a object transformed by the graphql-yoga package. Had to replace it with Object.prototype.toString() and now it works.
|
Directly method calls from If you make a test for this case it will be very cool. |
That's better.
That's better :)
|
Can you check my fix on your case? |
zbitname
reviewed
Jul 26, 2018
index.js
Outdated
| */ | ||
| function isObject(value) { | ||
| return value && value.toString() === '[object Object]'; | ||
| return value && Object.prototype.toString(value) === '[object Object]'; |
There was a problem hiding this comment.
Object.prototype.toString() always return [object Object] and it's incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strangely enough, the .toString() method fires an error in nodejs when the value comes directly from a object transformed by the graphql-yoga package.
Had to replace it with Object.prototype.toString() and now it works.