fix(event): generate unique blockId for text stream events#1929
Open
itxaiohanglover wants to merge 1 commit into
Open
fix(event): generate unique blockId for text stream events#1929itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
The blockId in TextBlockStartEvent, TextBlockDeltaEvent, and TextBlockEndEvent was hardcoded as "text", violating the contract that blockId should be a unique identifier per text block. Generate a unique blockId (replyId + "_text_" + counter) each time a new text block starts, so consumers can distinguish multiple text blocks within a single reply. Fixes agentscope-ai#1899
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockId(replyId_text_N) for each text block instead of hardcoding"text"TextBlockStartEvent,TextBlockDeltaEvent, andTextBlockEndEventto use the generated IDAtomicIntegercounter toModelCallBlockLifecycleto track text block sequenceProblem
The
blockIdin text stream events was hardcoded as the fixed string"text", which violates the documentation specifying thatblockIdshould serve as a unique identifier for each text block. When a single reply contains multiple text blocks (e.g., text → tool call → more text), consumers cannot distinguish between them.Fixes #1899
Test Plan
blockId == "text"./gradlew :agentscope-core:testpasses