Skip to content

fix(sandbox): use updated WorkspaceSpec when resuming from persisted state #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Buktal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sandbox): use updated WorkspaceSpec when resuming from persisted state #1928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions agentscope-harness/src/main/java/io/agentscope/harness/agent/sandbox/SandboxManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ public SandboxAcquireResult acquire(
"[sandbox] Priority 3: resuming from persisted state (scope={})",
scopeKey.get());
SandboxState state = client.deserializeState(stateJson.get());
// Overwrite stale WorkspaceSpec with current application config
if (sandboxContext.getWorkspaceSpec() != null) {
state.setWorkspaceSpec(sandboxContext.getWorkspaceSpec().copy());
}
Sandbox sandbox = client.resume(state);
return SandboxAcquireResult.selfManaged(sandbox, lease);
}
Expand Down
Loading