Skip to content

fix: propagate Reactor context to chunk event hooks#1923

Merged
oss-maintainer merged 3 commits into
agentscope-ai:mainfrom
chickenlj:fix-1823
Jun 26, 2026
Merged

fix: propagate Reactor context to chunk event hooks#1923
oss-maintainer merged 3 commits into
agentscope-ai:mainfrom
chickenlj:fix-1823

Conversation

@chickenlj

Copy link
Copy Markdown
Collaborator

Related to #1823

@chickenlj chickenlj requested review from a team and Copilot June 26, 2026 01:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…ncellation fix

After agentscope-ai#1796 added sink.onCancel(lifecycleDisposable), cancellation now
properly propagates to inner tool executions. The slow_tool's sleep is
interrupted before it can write to the file, so expect 0 lines instead
of 1.
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...e/src/main/java/io/agentscope/core/ReActAgent.java 91.83% 0 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@oss-maintainer oss-maintainer merged commit 2cfffc4 into agentscope-ai:main Jun 26, 2026
6 checks passed
@chickenlj chickenlj deleted the fix-1823 branch June 26, 2026 03:43
zhaojinyu pushed a commit to zhaojinyu/agentscope-java that referenced this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants