fix(agentrun): unwrap data envelopes#1920
Open
guslegend0510 wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
Nice fix — the |
Contributor
|
Clean fix! Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.0-SNAPSHOT
Description
This PR fixes AgentRun data-plane JSON handling when successful responses are wrapped in a
dataenvelope.Background:
AgentRunDataPlaneHttppreviously parsed response JSON from the root node.data, so fields likeidandstatuswere not visible to the client code.Changes made:
unwrapData(...)inAgentRunDataPlaneHttpand applied it ingetJson()andpostJson().AgentRunDataPlaneHttpTestto mock wrapped responses and verify parsing still works.Related issues:
AgentRunDataPlaneHttp响应 JSONdata信封未解包 #1907How to test:
mvn -pl agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-agentrun -am -Dtest=AgentRunDataPlaneHttpTest test