fix(skill): upload resource files under skill name#1919
Open
guslegend0510 wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.0-SNAPSHOT
Description
Fixes issue #1906: when a skill directory contains files other than
SKILL.md,uploadSkillFiles()previously usedskillIdas the upload directory. For classpath-based skills,skillIdmay include a source-qualified prefix, which causes resource files to be written to the wrong path. This PR switches the upload target toskill.getName()and adds a regression test for uploading sibling resources such asSOUL.md.Changes Made
How to Test
mvn -pl agentscope-core -Dtest=SkillBoxTest testRelated Issue