Skip to content

fix(dashscope): forward structured response format #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guslegend0510 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(dashscope): forward structured response format #1865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b6eb12
fix(dashscope): forward structured response format
guslegend Jun 22, 2026
bc3ab46
Merge branch 'main' into fix/issue-1852-dashscope-structured-output
guslegend0510 Jun 23, 2026
b4c3560
test(dashscope): cover json_object response format
guslegend Jun 23, 2026
41aef4f
Merge branch 'main' into fix/issue-1852-dashscope-structured-output
guslegend0510 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...scope-core/src/main/java/io/agentscope/core/formatter/dashscope/DashScopeToolsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ public void applyOptions(
params.setPresencePenalty(presencePenalty);
}

var responseFormat = getOption(options, defaultOptions, GenerateOptions::getResponseFormat);
if (responseFormat != null) {
params.setResponseFormat(responseFormat);
}

// Apply parallel tool calls
Boolean parallelToolCalls =
getOption(options, defaultOptions, GenerateOptions::getParallelToolCalls);
Expand Down
23 changes: 22 additions & 1 deletion ...st/java/io/agentscope/core/formatter/dashscope/DashScopeToolsHelperComprehensiveTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
Comment thread
guslegend0510 marked this conversation as resolved.

import io.agentscope.core.formatter.ResponseFormat;
import io.agentscope.core.formatter.dashscope.dto.DashScopeParameters;
import io.agentscope.core.formatter.dashscope.dto.DashScopeTool;
import io.agentscope.core.formatter.dashscope.dto.DashScopeToolCall;
import io.agentscope.core.formatter.openai.dto.JsonSchema;
import io.agentscope.core.message.ToolUseBlock;
import io.agentscope.core.model.GenerateOptions;
import io.agentscope.core.model.ToolChoice;
Expand Down Expand Up @@ -112,6 +114,12 @@ void testApplyOptionsWithAllOptions() {
.topP(0.9)
.maxTokens(1024)
.thinkingBudget(500)
.responseFormat(
ResponseFormat.jsonSchema(
JsonSchema.builder()
.name("WeatherResponse")
.schema(Map.of("type", "object"))
.build()))
.build();

helper.applyOptions(params, options, null);
Expand All @@ -121,18 +129,31 @@ void testApplyOptionsWithAllOptions() {
assertEquals(1024, params.getMaxTokens());
assertEquals(500, params.getThinkingBudget());
assertTrue(params.getEnableThinking());
assertNotNull(params.getResponseFormat());
assertEquals("json_schema", params.getResponseFormat().getType());
}

@Test
void testApplyOptionsWithDefaultOptions() {
DashScopeParameters params = DashScopeParameters.builder().build();
GenerateOptions defaultOptions =
GenerateOptions.builder().temperature(0.7).maxTokens(512).build();
GenerateOptions.builder()
.temperature(0.7)
.maxTokens(512)
.responseFormat(
ResponseFormat.jsonSchema(
JsonSchema.builder()
.name("DefaultResponse")
.schema(Map.of("type", "object"))
.build()))
.build();

helper.applyOptions(params, null, defaultOptions);

assertEquals(0.7, params.getTemperature());
assertEquals(512, params.getMaxTokens());
assertNotNull(params.getResponseFormat());
assertEquals("json_schema", params.getResponseFormat().getType());
}

@Test
Expand Down
Loading