Skip to content

Fix/ when we use Sandbox,RemoteSandboxSnapshot deserialize fail and do not reject remoteSnapshot to State #1863

Open
zhaojinyu wants to merge 1 commit into
agentscope-ai:mainfrom
zhaojinyu:fix/RemoteSandboxSnapshot_bug
Open

Fix/ when we use Sandbox,RemoteSandboxSnapshot deserialize fail and do not reject remoteSnapshot to State #1863
zhaojinyu wants to merge 1 commit into
agentscope-ai:mainfrom
zhaojinyu:fix/RemoteSandboxSnapshot_bug

Conversation

@zhaojinyu

Copy link
Copy Markdown
Contributor

AgentScope-Java Version

2.0.0-SNAPSHOT

Description

when we use Sandbox,RemoteSandboxSnapshot deserialize fail and do not reject remoteSnapshot to State
I reInject remoteSnapshot and add @JsonIgnoreProperties @JsonIgnore @JsonCreator in RemoteSandboxSnapshot

Checklist

Please check the following items before code is ready to be reviewed.

  • [OK ] Code has been formatted with mvn spotless:apply
  • [OK ] All tests are passing (mvn test)
  • [OK ] Javadoc comments are complete and follow project conventions
  • [OK ] Related documentation has been updated (e.g. links, examples, etc.)
  • [ OK] Code is ready for review

@zhaojinyu zhaojinyu requested a review from a team June 22, 2026 10:49
…ate correctly and we need reinject remotesanpshot after deserialize
@zhaojinyu zhaojinyu force-pushed the fix/RemoteSandboxSnapshot_bug branch from d711034 to 77a88b1 Compare June 22, 2026 11:08
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...entscope/harness/agent/sandbox/SandboxManager.java 37.50% 4 Missing and 1 partial ⚠️
.../agent/sandbox/snapshot/RemoteSandboxSnapshot.java 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AgentScopeJavaBot AgentScopeJavaBot added bug Something isn't working area/harness agentscope-harness (test/runtime support) labels Jun 23, 2026

@AgentScopeJavaBot AgentScopeJavaBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/harness agentscope-harness (test/runtime support) bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants