feat(tool): expose MCP output schemas in tool definitions#1221
Merged
LearningGp merged 2 commits intoApr 29, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
LearningGp
requested changes
Apr 28, 2026
Contributor
Author
|
Addressed the review point in Re-ran targeted validation:
|
liangxingguang
pushed a commit
to liangxingguang/agentscope-java
that referenced
this pull request
May 21, 2026
…-ai#1221) ## Summary - expose MCP `outputSchema` through `AgentTool`, `McpTool`, and `ToolSchema` - preserve output schemas when registering MCP tools via `McpClientManager` - add regression coverage for schema propagation and toolkit exposure ## Why this fix `McpSchema.Tool` already provides `outputSchema()`, but the current registration flow drops it before the tool reaches AgentScope's tool schema layer. This prevents downstream consumers from seeing structured output contracts for MCP-backed tools. ## Validation - `mvn -pl agentscope-core -Dtest=McpClientManagerTest,ExternalToolSupportTest,ToolSchemaProviderTest,McpToolTest,ToolkitTest test -q` - `mvn -pl agentscope-core spotless:check -q`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outputSchemathroughAgentTool,McpTool, andToolSchemaMcpClientManagerWhy this fix
McpSchema.Toolalready providesoutputSchema(), but the current registration flow drops it before the tool reaches AgentScope's tool schema layer. This prevents downstream consumers from seeing structured output contracts for MCP-backed tools.Validation
mvn -pl agentscope-core -Dtest=McpClientManagerTest,ExternalToolSupportTest,ToolSchemaProviderTest,McpToolTest,ToolkitTest test -qmvn -pl agentscope-core spotless:check -q