fix(SkillFileSystemHelper): Fixed an issue where an existing skill prevented other skills from being saved.#1049
Merged
Merged
Conversation
当技能目录已存在且强制覆盖标志为false时，现在将跳过该技能而不是返回失败状态。这样可以允许批量处理多个技能而不会因为单个技能的存在而导致整个流程中断。
|
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
LGTM🚀 |
Collaborator
|
plz add a test to verify whether there has been no coverage at all.Add a test to verify whether overwriting does not occur when force is set to false. |
Contributor
Author
|
I have already added tests to ensure new skills can be saved and existing skills will not be modified. |
fang-tech
approved these changes
Mar 30, 2026
fang-tech
left a comment
fang-tech
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, plz change your pr title to English
superjvjkdf
changed the title
Contributor
Author
|
done |
liangxingguang
pushed a commit
to liangxingguang/agentscope-java
that referenced
this pull request
May 21, 2026
…evented other skills from being saved. (agentscope-ai#1049) ## AgentScope-Java Version 1.0.10 [The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run `mvn dependency:tree | grep agentscope-parent:pom`(only mac/linux)] ## Description [Please describe the background, purpose, changes made, and how to test this PR] 当技能目录已存在且强制覆盖标志为false时，现在将跳过该技能而不是返回失败状态。这样可以保存后续技能而不会因为单个技能的存在而导致其他技能无法保存。 ## Checklist Please check the following items before code is ready to be reviewed. - [x] Code has been formatted with `mvn spotless:apply` - [x] All tests are passing (`mvn test`) - [ ] Javadoc comments are complete and follow project conventions - [ ] Related documentation has been updated (e.g. links, examples, etc.) - [x] Code is ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.10
[The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
当技能目录已存在且强制覆盖标志为false时，现在将跳过该技能而不是返回失败状态。这样可以保存后续技能而不会因为单个技能的存在而导致其他技能无法保存。
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)