Skip to content

Level 1/2 conformance tests are permanently-skipped stubs #8

Description

@imran-siddique

tests/test_level1.py and tests/test_level2.py are class-level @pytest.mark.skip stubs whose test bodies are all raise NotImplementedError. They also reference fixtures that do not exist in conftest.py (signed_eat_bytes, challenge_nonce, trust_record, attestation_report), so even without the skip marker they could not run.

Why this matters: these are the only tests covering signature verification (COSE_Sign1 envelope, signature against the cnf key, nonce/challenge binding) and TEE measurement verification (measurement vs attestation report, report freshness, platform/report format match). As written they can never fail, so the suite reports green while the highest-value conformance checks are entirely unimplemented. The skips are easy to misread as environmental rather than "not implemented".

Recommendation:

  • Implement the Level 1 tests against a signed EAT fixture (the unit suite already generates Ed25519-signed cmcp records in tests/unit/test_tr_sig.py, so the building blocks exist), and the Level 2 tests against captured attestation report fixtures.
  • Until then, mark them xfail(strict=False, reason="not implemented") or fail loudly in CI summary output so the implementation gap stays visible, and remove the references to nonexistent fixtures.

Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions