Skip to content

test(sandbox): name verify_record(expected_nonce=...) in the docstring #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imran-siddique wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

test(sandbox): name verify_record(expected_nonce=...) in the docstring #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/test_sandbox_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,10 @@ def test_genuinely_verified_evidence_is_still_not_bound_to_the_signing_key() ->
asks of them -- still cannot get real Level 1 assurance out of this adapter, because
nothing here binds that evidence to the specific key the record ends up signed
with. ``nonce`` is carried through verbatim and is never checked against
``cnf.jwk``, against the signing key passed to ``sign_record``, or against
anything else. Two records built from the identical (hypothetically genuine)
attestation but signed with unrelated, unrelated-to-the-hardware keys both verify
``cnf.jwk`` or against the signing key passed to ``sign_record``. A verifier can
compare it against a value it chose, via ``verify_record(expected_nonce=...)``,
which establishes freshness rather than key binding. Two records built from the
identical (hypothetically genuine) attestation but signed with unrelated keys both verify
successfully; nothing distinguishes "the verified key" from "any key the caller
felt like using afterwards". Per docs/trust-levels.md, Level 1 requires
"authenticated evidence binding the record-signing key to the expected
Expand Down