Skip to content

Fail fast when demo services exit - #42

Merged
imran-siddique merged 1 commit into
mainfrom
agent/fail-fast-demo-launchers
Aug 12, 2026
Merged

Fail fast when demo services exit#42
imran-siddique merged 1 commit into
mainfrom
agent/fail-fast-demo-launchers

Conversation

@imran-siddique

Copy link
Copy Markdown
Member

What changed

  • Readiness loops now detect child processes that exit before binding their port
  • Error messages include the exit code and point to launcher logs
  • The top-level runner bounds each demo to 180 seconds
  • Applies the behavior consistently to demos 1, 2, 4, 5, 10 and the web console

Root cause

The launchers only polled a TCP port. If a child failed during startup, users waited the full readiness timeout with no indication that the process had already exited.

Validation

  • Compiled every changed Python file
  • Reproduced an immediate cMCP startup failure
  • Confirmed failure returned in about 10 seconds with the child exit code
  • Confirmed no demo server process remained
  • Ran git diff --check

@imran-siddique
imran-siddique marked this pull request as ready for review August 12, 2026 23:05
@imran-siddique
imran-siddique merged commit 4309c7c into main Aug 12, 2026
3 checks passed
@imran-siddique
imran-siddique deleted the agent/fail-fast-demo-launchers branch August 12, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant