fix(startup): reject unknown TEE provider names at startup (HW-001) - #232
Merged
Conversation
…loses #171) Add _VALID_PROVIDERS frozenset to startup.py and validate attestation_report.provider immediately after attestation succeeds. An unrecognised provider name calls _fatal() and exits 1 before the value can propagate into TRACE Claims or Cedar policy context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_VALID_PROVIDERS: frozenset[str]constant tostartup.pywith the five canonical provider names (sev-snp,tdx,opaque,tpm,software-only), mirroring the keys of_PROVIDER_MAPinaudit/trace_claim.pywithout creating a circular importattestation_report.provideragainst that allowlist immediately after attestation succeeds; calls_fatal("ATTESTATION_PROVIDER_INVALID", ...)andsys.exit(1)on any unknown value, preventing the string from propagating into TRACE Claims or Cedar policy contextTest plan
test_startup_fails_on_unknown_tee_provider_name: mocksSoftwareOnlyProvider.get_attestation_reportto return a report withprovider="evil-custom-tee"and assertssys.exit(1)pytest tests/unit/test_startup.py -vlocally — all green🤖 Generated with Claude Code