chore: apply ruff format, and gate it so it cannot drift again - #93
Merged
Conversation
34 of 77 files were unformatted, almost all of them predating any current work. ruff format is not a CI gate here (ci.yml runs ruff check and mypy only), which is why the drift accumulated silently. Formatting only. No behaviour change: ruff check passes and the suite is 367 passed / 3 skipped, unchanged from before. Done as its own commit so it does not sit inside a change with real content, and so the git blame noise is isolated to one reviewable diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The sweep in the previous commit fixed 34 files; without a gate it would just re-accumulate. ruff check does not cover formatting, which is why nobody noticed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting only, plus the gate that stops it recurring.
What
ruff formathad never been enforced here, so 34 of 77 files had drifted out of format — almost all of them predating any current work.ci.ymlrunsruff checkandmypy, and neither covers formatting, which is why it accumulated silently.Two commits, deliberately separate:
chore: apply ruff format— the mechanical reformat. No behaviour change:ruff checkpasses and the suite is 367 passed / 3 skipped, identical to before.ci: gate ruff format— addsruff format --check src/ tests/to the lint job, so the drift cannot reaccumulate. Checked, not applied, so CI never rewrites anyone's code.Timing
ca2ahas no other open PRs right now, which is the cheapest possible moment to land a repo-wide reformat — nothing in flight gets a conflict.Reviewing this
The diff is large and entirely uninteresting;
git show --statper commit is the useful view. If you would rather not carry thegit blamenoise, the honest alternative is to drop commit 1 and keep only the gate, but then CI fails until the files are formatted, so it would have to be all-or-nothing.Worth knowing: the example artifacts (
examples/*/chain.json,dag.json) regenerate with fresh keys on every demo run, so running the suite dirties the working tree. That churn is excluded from this PR — it is a pre-existing wart, not part of this change.🤖 Generated with Claude Code