Skip to content

fix(deps): add missing prometheus-client to dev lockfile - #408

Merged
imran-siddique merged 1 commit into
agentrust-io:mainfrom
rajnisht7:fix-prometheus-client-lockfile
Sep 8, 2026
Merged

fix(deps): add missing prometheus-client to dev lockfile#408
imran-siddique merged 1 commit into
agentrust-io:mainfrom
rajnisht7:fix-prometheus-client-lockfile

Conversation

@rajnisht7

Copy link
Copy Markdown
Contributor

What

Adds prometheus-client to requirements/dev.in and regenerates requirements/dev.txt.

Why

pyproject.toml's dev extra declares prometheus-client>=0.20,<1 (needed for the operations/monitoring.md tutorial test), but requirements/dev.in never had it so requirements/dev.txt, the file CI actually installs via pip install --require-hashes, was missing it too.

Due to this test_followup_tutorial[operations/monitoring.md-expected0] to fail with `ModuleNotFoundError: No module named 'prometheus_client.

Spec impact

None

Test plan

  • pytest -v passes
  • mypy src/agent_manifest passes
  • ruff check src/ tests/ passes
  • New or updated tests cover the change
  • If spec change: CHANGELOG.md updated

DCO

All commits in this PR are signed off (git commit -s). By submitting this PR I certify the Developer Certificate of Origin.

Signed-off-by: rajnisht7 <rajnishtiwari9787@gmail.com>

@imran-siddique imran-siddique left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging. This is the repository's red, not a nicety: test_docs_first_manifest.py::test_followup_tutorial[operations/monitoring.md] is failing on ModuleNotFoundError: No module named 'prometheus_client' on main and on every open PR here, across all five platform jobs. I checked main's own run rather than inferring it from a PR.

The diagnosis in your body is exactly right and worth restating because the failure mode is easy to reintroduce. pyproject.toml's dev extra declares prometheus-client>=0.20,<1, requirements/dev.in never listed it, and CI installs requirements/dev.txt with --require-hashes. So the declared development dependency and the installed one are two different facts, and nothing in the pipeline compares them: a dependency can be declared and simply never installed, and the only symptom is a test that imports it.

The fix follows the repository's own pattern rather than shortcutting it: the constraint goes in dev.in, dev.txt is regenerated with both hashes and the # via -r requirements/dev.in provenance line kept. A hand-added pin without a regenerated hash block would have failed --require-hashes on the next resolve.

Worth naming for whoever picks this up next: #407 is yours too, and its five red Test jobs are entirely this, nothing to do with its own diff. That is the cost of a shared failure sitting under a queue, and it is why this one goes first.

@imran-siddique
imran-siddique merged commit d5262c8 into agentrust-io:main Sep 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants