Skip to content

Refine MPP#8

Merged
Haakam21 merged 5 commits intomainfrom
haakam/eng-300-sdks-x402mpp
Feb 27, 2026
Merged

Refine MPP#8
Haakam21 merged 5 commits intomainfrom
haakam/eng-300-sdks-x402mpp

Conversation

@Haakam21
Copy link
Contributor

@Haakam21 Haakam21 commented Feb 27, 2026

Summary by cubic

Renamed the MPP integration to MPPX and added a local MppxClient. AgentMailClient now uses the mppx option for fetch and websocket payment credentials.

  • Refactors

    • Replaced mpp with mppx across Client, websockets helper, and tests.
    • Added mppx.ts with MppxClient and getPaymentCredentials; removed mpp-types.d.ts and mpp.ts.
    • Moved probe402 into util.ts with wsToHttp; updated mppx and x402 to use it; removed probe402.ts.
  • Migration

    • Change AgentMailClient options from { mpp: ... } to { mppx: ... }.
    • Update imports to use wrapper/mppx instead of wrapper/mpp.

Written for commit e929ebf. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/wrapper/mppx.ts">

<violation number="1" location="src/wrapper/mppx.ts:15">
P1: `new Request(wsUrl)` uses a wss/ws URL from the websockets environment, which fetch Request does not support. Convert the websocket URL to http/https before creating the Request to avoid a runtime TypeError.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@Haakam21
Copy link
Contributor Author

@cubic

@cubic-dev-ai
Copy link

cubic-dev-ai bot commented Feb 27, 2026

@cubic

@Haakam21 I have started the AI code review. It will take a few minutes to complete.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@Haakam21 Haakam21 merged commit d9a18ec into main Feb 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant