feat: PAAL-123 fix linter issues

Author: qa-jil-kamerling

internal/controller/agent_controller.go

@@ -41,6 +41,7 @@ const (
 	agentContainerName   = "agent"
 	agentCardEndpoint    = "/.well-known/agent-card.json"
 	a2aAgentCardEndpoint = "/a2a/.well-known/agent-card.json"
+	a2AProtocol          = "A2A"
 )
 
 // AgentReconciler reconciles a Agent object
@@ -361,7 +362,8 @@ func (r *AgentReconciler) mergeEnvironmentVariables(templateEnvVars, userEnvVars
 // hasA2AProtocol checks if the agent has A2A protocol configured
 func (r *AgentReconciler) hasA2AProtocol(agent *runtimev1alpha1.Agent) bool {
 	for _, protocol := range agent.Spec.Protocols {
-		if protocol.Type == "A2A" {
+
+		if protocol.Type == a2AProtocol {
 			return true
 		}
 	}
@@ -381,7 +383,7 @@ func (r *AgentReconciler) hasOpenAIProtocol(agent *runtimev1alpha1.Agent) bool {
 // getA2AProtocol returns the first A2A protocol configuration found
 func (r *AgentReconciler) getA2AProtocol(agent *runtimev1alpha1.Agent) *runtimev1alpha1.AgentProtocol {
 	for _, protocol := range agent.Spec.Protocols {
-		if protocol.Type == "A2A" {
+		if protocol.Type == a2AProtocol {
 			return &protocol
 		}
 	}
@@ -847,7 +849,7 @@ func (r *AgentReconciler) sanitizeAgentName(name string) string {
 func (r *AgentReconciler) buildA2AAgentCardUrl(agent *runtimev1alpha1.Agent) string {
 	// Find the A2A protocol
 	for _, protocol := range agent.Spec.Protocols {
-		if protocol.Type == "A2A" {
+		if protocol.Type == a2AProtocol {
 			return fmt.Sprintf("http://%s.%s.svc.cluster.local:%d%s",
 				agent.Name, agent.Namespace, protocol.Port, protocol.Path)
 		}

internal/controller/agent_controller_test.go

@@ -21,8 +21,6 @@ import (
 	"fmt"
 
 	webhookv1alpha1 "github.com/agentic-layer/agent-runtime-operator/internal/webhook/v1alpha1"
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
@@ -144,7 +142,7 @@ var _ = Describe("Agent Controller", func() {
 			probe := reconciler.generateReadinessProbe(agent)
 			Expect(probe).NotTo(BeNil())
 			Expect(probe.HTTPGet).NotTo(BeNil())
-			Expect(probe.HTTPGet.Path).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(probe.HTTPGet.Path).To(Equal(a2aAgentCardEndpoint))
 			Expect(probe.HTTPGet.Port.IntValue()).To(Equal(8000))
 			Expect(probe.InitialDelaySeconds).To(Equal(int32(10)))
 		})
@@ -178,7 +176,7 @@ var _ = Describe("Agent Controller", func() {
 			probe := reconciler.generateReadinessProbe(agent)
 			Expect(probe).NotTo(BeNil())
 			Expect(probe.HTTPGet).NotTo(BeNil())
-			Expect(probe.HTTPGet.Path).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(probe.HTTPGet.Path).To(Equal(a2aAgentCardEndpoint))
 		})
 
 		It("should return nil probe for agents with no recognized protocols", func() {
@@ -242,7 +240,7 @@ var _ = Describe("Agent Controller", func() {
 			Expect(probe).NotTo(BeNil())
 			Expect(probe.HTTPGet).NotTo(BeNil())
 			Expect(probe.HTTPGet.Port.IntValue()).To(Equal(3000))
-			Expect(probe.HTTPGet.Path).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(probe.HTTPGet.Path).To(Equal(a2aAgentCardEndpoint))
 		})
 
 		It("should use custom port from OpenAI protocol", func() {
@@ -304,7 +302,7 @@ var _ = Describe("Agent Controller", func() {
 			probe := reconciler.generateReadinessProbe(agent)
 			Expect(probe).NotTo(BeNil())
 			Expect(probe.HTTPGet).NotTo(BeNil())
-			Expect(probe.HTTPGet.Path).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(probe.HTTPGet.Path).To(Equal(a2aAgentCardEndpoint))
 			Expect(probe.HTTPGet.Port.IntValue()).To(Equal(8000))
 		})
 
@@ -426,11 +424,11 @@ var _ = Describe("Agent Controller", func() {
 			// Test with unspecified path field (should use default /a2a)
 			protocolNoPath := &runtimev1alpha1.AgentProtocol{Type: "A2A"}
 			pathDefault := reconciler.getA2AHealthPath(protocolNoPath)
-			Expect(pathDefault).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(pathDefault).To(Equal(a2aAgentCardEndpoint))
 
 			// Test with nil protocol (should use default)
 			pathNil := reconciler.getA2AHealthPath(nil)
-			Expect(pathNil).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(pathNil).To(Equal(a2aAgentCardEndpoint))
 		})
 	})
 
@@ -659,7 +657,7 @@ var _ = Describe("Agent Controller", func() {
 			desiredContainer := reconciler.findAgentContainer(desiredDeployment.Spec.Template.Spec.Containers)
 
 			Expect(existingContainer.ReadinessProbe.HTTPGet.Path).To(Equal("/health"))
-			Expect(desiredContainer.ReadinessProbe.HTTPGet.Path).To(Equal(fmt.Sprintf(a2aAgentCardEndpoint)))
+			Expect(desiredContainer.ReadinessProbe.HTTPGet.Path).To(Equal(a2aAgentCardEndpoint))
 		})
 
 		It("should not trigger update when probes are identical", func() {