feat: PAAL-123 remove delay of readiness probe for agents with subagents; remove tools from sample

Author: qa-jil-kamerling

config/samples/kustomization.yaml

@@ -3,6 +3,5 @@ resources:
 - runtime_v1alpha1_agent.yaml
 - runtime_v1alpha1_agent_template.yaml
 - runtime_v1alpha1_agent_openai.yaml
-- runtime_v1alpha1_agent_no_probe.yaml
 - configmap.yaml
 # +kubebuilder:scaffold:manifestskustomizesamples

config/samples/runtime_v1alpha1_agent_no_probe.yaml

@@ -13,11 +13,12 @@ spec:
   subAgents:
     - name: summarizer_agent
       url: "https://agents.example.com/summarizer-agent.json"
-  tools:
-    - name: news_fetcher
-      url: "https://news.mcpservers.org/fetch/mcp"
-    - name: web_fetch
-      url: "https://remote.mcpservers.org/fetch/mcp"
+#  Uncommented for now since health probe needs working mcp tools
+#  tools:
+#    - name: news_fetcher
+#      url: "https://news.mcpservers.org/fetch/mcp"
+#    - name: web_fetch
+#      url: "https://remote.mcpservers.org/fetch/mcp"
   protocols:
     - type: A2A
       path: "/"

config/samples/runtime_v1alpha1_agent_template.yaml

@@ -424,7 +424,6 @@ func (r *AgentReconciler) getA2AHealthPath(protocol *runtimev1alpha1.AgentProtoc
 // generateReadinessProbe generates appropriate readiness probe based on agent protocols
 func (r *AgentReconciler) generateReadinessProbe(agent *runtimev1alpha1.Agent) *corev1.Probe {
 	// Check if agent has external dependencies (subAgents or tools)
-	hasExternalDeps := len(agent.Spec.SubAgents) > 0 || len(agent.Spec.Tools) > 0
 
 	// Priority: A2A > OpenAI > None
 	if r.hasA2AProtocol(agent) {
@@ -434,21 +433,15 @@ func (r *AgentReconciler) generateReadinessProbe(agent *runtimev1alpha1.Agent) *
 		port := r.getProtocolPort(a2aProtocol, 8000)
 
 		probe := r.buildA2AReadinessProbe(healthPath, port)
-		if hasExternalDeps {
-			// More generous timing for agents with external dependencies
-			return delay(probe, 180, 20, 10)
-		}
+
 		return probe
 	} else if r.hasOpenAIProtocol(agent) {
 		// Use TCP probe for OpenAI-only agents
 		openaiProtocol := r.getOpenAIProtocol(agent)
 		port := r.getProtocolPort(openaiProtocol, 8000)
 
 		probe := r.buildOpenAIReadinessProbe(port)
-		if hasExternalDeps {
-			// More generous timing for agents with external dependencies
-			return delay(probe, 180, 20, 10)
-		}
+
 		return probe
 	}
 
@@ -904,13 +897,3 @@ func (r *AgentReconciler) buildA2AReadinessProbe(healthPath string, port int32)
 		FailureThreshold:    3,
 	}
 }
-
-// delay modifies probe timing settings for agents with external dependencies
-func delay(probe *corev1.Probe, initialDelaySeconds int32, timeoutSeconds int32, failureThreshold int32) *corev1.Probe {
-	if probe != nil {
-		probe.InitialDelaySeconds = initialDelaySeconds
-		probe.TimeoutSeconds = timeoutSeconds
-		probe.FailureThreshold = failureThreshold
-	}
-	return probe
-}