feat: PAAL-123 delay readiness probe for agents with subagents

Author: qa-jil-kamerling

internal/controller/agent_controller.go

@@ -423,43 +423,33 @@ func (r *AgentReconciler) getA2AHealthPath(protocol *runtimev1alpha1.AgentProtoc
 
 // generateReadinessProbe generates appropriate readiness probe based on agent protocols
 func (r *AgentReconciler) generateReadinessProbe(agent *runtimev1alpha1.Agent) *corev1.Probe {
+	// Check if agent has external dependencies (subAgents or tools)
+	hasExternalDeps := len(agent.Spec.SubAgents) > 0 || len(agent.Spec.Tools) > 0
+
 	// Priority: A2A > OpenAI > None
 	if r.hasA2AProtocol(agent) {
 		// Use A2A agent card endpoint for health check
 		a2aProtocol := r.getA2AProtocol(agent)
 		healthPath := r.getA2AHealthPath(a2aProtocol)
 		port := r.getProtocolPort(a2aProtocol, 8000)
 
-		return &corev1.Probe{
-			ProbeHandler: corev1.ProbeHandler{
-				HTTPGet: &corev1.HTTPGetAction{
-					Path: healthPath,
-					Port: intstr.FromInt(int(port)),
-				},
-			},
-			InitialDelaySeconds: 10,
-			PeriodSeconds:       5,
-			TimeoutSeconds:      3,
-			SuccessThreshold:    1,
-			FailureThreshold:    3,
+		probe := r.buildA2AReadinessProbe(healthPath, port)
+		if hasExternalDeps {
+			// More generous timing for agents with external dependencies
+			return delay(probe, 180, 20, 10)
 		}
+		return probe
 	} else if r.hasOpenAIProtocol(agent) {
 		// Use TCP probe for OpenAI-only agents
 		openaiProtocol := r.getOpenAIProtocol(agent)
 		port := r.getProtocolPort(openaiProtocol, 8000)
 
-		return &corev1.Probe{
-			ProbeHandler: corev1.ProbeHandler{
-				TCPSocket: &corev1.TCPSocketAction{
-					Port: intstr.FromInt(int(port)),
-				},
-			},
-			InitialDelaySeconds: 10,
-			PeriodSeconds:       5,
-			TimeoutSeconds:      3,
-			SuccessThreshold:    1,
-			FailureThreshold:    3,
+		probe := r.buildOpenAIReadinessProbe(port)
+		if hasExternalDeps {
+			// More generous timing for agents with external dependencies
+			return delay(probe, 180, 20, 10)
 		}
+		return probe
 	}
 
 	// No recognized protocols - no readiness probe
@@ -881,3 +871,46 @@ func (r *AgentReconciler) SetupWithManager(mgr ctrl.Manager) error {
 		Named("agent").
 		Complete(r)
 }
+
+// buildOpenAIReadinessProbe creates TCP-readiness-probe for OpenAI-protocols
+func (r *AgentReconciler) buildOpenAIReadinessProbe(port int32) *corev1.Probe {
+	return &corev1.Probe{
+		ProbeHandler: corev1.ProbeHandler{
+			TCPSocket: &corev1.TCPSocketAction{
+				Port: intstr.FromInt(int(port)),
+			},
+		},
+		InitialDelaySeconds: 10,
+		PeriodSeconds:       5,
+		TimeoutSeconds:      3,
+		SuccessThreshold:    1,
+		FailureThreshold:    3,
+	}
+}
+
+// buildA2AReadinessProbe creates HTTP-readiness-probe for A2A-protocols.
+func (r *AgentReconciler) buildA2AReadinessProbe(healthPath string, port int32) *corev1.Probe {
+	return &corev1.Probe{
+		ProbeHandler: corev1.ProbeHandler{
+			HTTPGet: &corev1.HTTPGetAction{
+				Path: healthPath,
+				Port: intstr.FromInt(int(port)),
+			},
+		},
+		InitialDelaySeconds: 10,
+		PeriodSeconds:       5,
+		TimeoutSeconds:      3,
+		SuccessThreshold:    1,
+		FailureThreshold:    3,
+	}
+}
+
+// delay modifies probe timing settings for agents with external dependencies
+func delay(probe *corev1.Probe, initialDelaySeconds int32, timeoutSeconds int32, failureThreshold int32) *corev1.Probe {
+	if probe != nil {
+		probe.InitialDelaySeconds = initialDelaySeconds
+		probe.TimeoutSeconds = timeoutSeconds
+		probe.FailureThreshold = failureThreshold
+	}
+	return probe
+}