Make router health checks bounded and non-blocking#491
Open
Yiqing Wang (YQ-Wang) wants to merge 1 commit into
Open
Make router health checks bounded and non-blocking#491Yiqing Wang (YQ-Wang) wants to merge 1 commit into
Yiqing Wang (YQ-Wang) wants to merge 1 commit into
Conversation
Yiqing Wang (YQ-Wang)
marked this pull request as ready for review
July 22, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/versionhealth check observe the router context and a 500 ms dependency timeout/statuszto serve the most recently completed reportRoot cause
The client-go
Discovery().ServerVersion()helper usescontext.TODO()internally. If the Kubernetes API accepted/versionbut withheld its response, canceling the router context could not terminate the request. The router also held the report mutex across dependency network calls, so the stalled request blocked/statuszand delayed shutdown.Validation
make verifygo test ./cmd/atenet/internal/router -run 'Test(CheckK8s|HealthCheck|HealthStart)' -count=20go test -race ./cmd/atenet/internal/router -count=1/versionresponse and withheld it;/statuszremained responsive with HTTP 200, the request was canceled at the 500 ms deadline, and one Kubernetes health failure was recordedFixes #490