Repository navigation
fix(i18n): localize hardcoded tooltips and aria-labels - #668
Merged
Merged
Conversation
sleepinginsummer
pushed a commit
to sleepinginsummer/pi-web
that referenced
this pull request
Sep 9, 2026
Co-authored-by: Alex Yang <agegcn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A few user-facing strings in
ChatInputandChatMinimapwere still hardcoded in English, so they rendered untranslated when the UI was set to Simplified or Traditional Chinese. This routes them through the i18n layer.Changes
ChatInput
ModelErrorBannerandModelScopeWarningBannernow useuseI18n()for their titles.titleattributes on the "Input history" panel header and the Steer / Follow-up buttons.ChatMinimap
aria-labelandtitleof the "Locate assistant message" jump button.Messages
Added 7 keys to
en,zh-CN, andzh-TW:chat.steerHintchat.followUpHintchat.inputHistorychat.modelErrorchat.modelScopeWarningchat.modelScopeWarningschatMinimap.locateAssistantNotes
docs/i18n.mdthattitle/aria-label/placeholdervalues go throught().components/ChatInput.test.mjsto render insideI18nProvider, since the banners now consume the i18n context.Testing
npm test— all passing.