Repository navigation
Warn when attached images go to a model without image input - #636
Merged
Merged
Conversation
/api/models now includes each model's input modalities in modelList, and the composer shows a dismissible warning banner when images are attached while the selected model is known not to accept image input. Unknown modality info and auto model selection stay silent.
sleepinginsummer
pushed a commit
to sleepinginsummer/pi-web
that referenced
this pull request
Sep 9, 2026
* Warn when attached images go to a model without image input (agegr#584) /api/models now includes each model's input modalities in modelList, and the composer shows a dismissible warning banner when images are attached while the selected model is known not to accept image input. Unknown modality info and auto model selection stay silent. * fix(chat): warn for resolved default models with image attachments --------- Co-authored-by: wuxiangru915 <wuxiangru915@users.noreply.github.com> Co-authored-by: Alex Yang <agegcn@gmail.com>
ghost0211
pushed a commit
to ghost0211/pi-web
that referenced
this pull request
Sep 29, 2026
* Warn when attached images go to a model without image input (agegr#584) /api/models now includes each model's input modalities in modelList, and the composer shows a dismissible warning banner when images are attached while the selected model is known not to accept image input. Unknown modality info and auto model selection stay silent. * fix(chat): warn for resolved default models with image attachments --------- Co-authored-by: wuxiangru915 <wuxiangru915@users.noreply.github.com> Co-authored-by: Alex Yang <agegcn@gmail.com> (cherry picked from commit 6d7c5e0)
ghost0211
added a commit
to ghost0211/pi-web
that referenced
this pull request
Sep 29, 2026
Batch upstream cherry-picks (agegr/pi-web) into the fork: Fixes - Guard against duplicate built-in command submissions (agegr#762) - Keep shell output across SSE reconnects; resume streaming output - See sessions written by another pi process (agegr#796) - Stop duplicating the first streamed chunk (agegr#835) - Deliver events to every listener when one unsubscribes mid-emit Features - Warn when attached images go to a model without image input (agegr#636) - Preview image attachments in the chat composer (agegr#735) - Render apply_patch tool calls as split diffs (agegr#744) - Scroll-to-latest floating button (agegr#845) Performance & deps - gzip large JSON responses (agegr#731) - Cache unchanged session metadata across scans and restarts (agegr#625) - Windowed session list (adapted to the fork's project-grouped sidebar) (agegr#626) - Next.js 16.3.6 + disable image optimizer; trim production install (agegr#948) Also includes the NSIS shortcut recreation hook (desktop icon fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #584
Problem
When the active model does not support image input, attached images are silently dropped. The composer gives no feedback and the model never sees the image.
Change
/api/modelsincludes each model'sinputmodalities inmodelList.ModelNoticeBannerto show a dismissible warning when attached images target a model known to lack image input, including a server-resolved default before the user explicitly selects a model.Verification
node --test components/ChatInput.test.mjs lib/models-cache.test.mjs hooks/model-scope-startup.test.mjs lib/model-scope.test.mjs hooks/model-switching.test.mjs: 52/52 pass.node_modules/.bin/tsc --noEmit --incremental false: clean.npm run lint: clean.