Repository navigation
fix(terminal): keep input alive when the phone keyboard collapses the… - #1160
Open
vill-jiang wants to merge 1 commit into
Open
vill-jiang wants to merge 1 commit into
vill-jiang wants to merge 1 commit into
Conversation
… panel Opening the soft keyboard on a phone shrinks --app-viewport-height, so xterm's fit can momentarily resize the terminal to one row. The resize API rejected rows < 2 with 400 "Invalid terminal command", and the writer's fail-closed rule then disabled input for good. Clamp rows to 2 on both the client and the route instead of rejecting.
Author
|
Retry CI/e2e |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the soft keyboard on a phone shrinks --app-viewport-height, so xterm's fit can momentarily resize the terminal to one row. The resize API rejected rows < 2 with 400 "Invalid terminal command", and the writer's fail-closed rule then disabled input for good. Clamp rows to 2 on both the client and the route instead of rejecting.
Screenrecorder-2026-10-10-14-36-19-799.mp4