Remove cabal flag cpphs
#6600
Merged
Remove cabal flag cpphs
#6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haskell's `cpphs` has not been actively maintained since 2020 and does not work correctly under Windows in some setups. hackage-trustees/malcolm-wallace-universe#20 Starting 2018 we have not been building with `cpphs` by default, but with the system CPP; no problems have been reported since then. Then, we already discussed removing cpphs entirely. #3223 I think we can go through with it now.
andreasabel
added
the
CPP
asr
approved these changes
May 1, 2023
|
Ok, then I merge this, we can undo should there be big protests. |
This was referenced May 2, 2023
andreasabel
added a commit
that referenced
this pull request
Aug 4, 2023
JobPetrovcic
pushed a commit
to JobPetrovcic/agda
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haskell's
cpphshas not been actively maintained since 2020 and does not work correctly under Windows in some setups.Starting 2018 we have not been building with
cpphsby default, but with the system CPP; no problems have been reported since then. Then, we already discussed removing cpphs entirely.I think we can go through with it now.