Added pop3 mailer and tools #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d4rk5eed
commented
Jan 30, 2018
d4rk5eed
commented
- Created Email.Protocol.Pop3 for pop3 protocol
- Created Email.Protocol.Pop3.Mock for testing
- Created Email.Protocol.Pop3.Mock for testing
DmitryKK
reviewed
Jan 31, 2018
lib/agala_email.ex
Outdated
| bot_params | ||
| Map.put( | ||
| bot_params, :private, %{ | ||
| mail_fetcher_module: (Mix.env() == :test &&@pop3_mock || @pop3) |
Member
There was a problem hiding this comment.
&&@pop3_mock - это какой-то особый синтаксис? непонятно немного
Contributor
Author
There was a problem hiding this comment.
&&@pop3_mock -> && @pop3_mock
Virviil
reviewed
Feb 1, 2018
lib/agala_email_receiver.ex
Outdated
| end) | ||
| end | ||
|
|
||
| defp mail_options(%BotParams{ |
Member
There was a problem hiding this comment.
Зачем этот метод вообще? Какой-то копипаст... Можно завернуть в provider_params.mail_params, или сделать Map.take...
Virviil
reviewed
Feb 1, 2018
mix.exs
Outdated
| {:credo, "~> 0.8", only: [:dev, :test]} | ||
| {:credo, "~> 0.8", only: [:dev, :test]}, | ||
| {:pop3mail, "~> 1.3"}, | ||
| {:erlpop, github: "nico-amsterdam/erlpop"} |
email helpers
fix helper module name
fetch update interval from config
Add pop3 mailer
Delete and quit
add missing methods to pop3_mock
Member
|
один из тестов сейчас падает |
Add pop3 mailer
Merge pull request #2 from agalaframework/add-pop3-mailer
Member
|
Теперь тесты проходят |
Add email reply
Add pop3 mailer
Logging on get updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.