Add tests for XREADGROUP vs XAUTOCLAIM selection based on min_idle_time #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n min_idle_time Add comprehensive tests to verify correct method selection in Redis stream subscribers: - Test XAUTOCLAIM usage when min_idle_time is set - Test XREADGROUP usage when min_idle_time is not set - Cover batch mode, get_one(), and iterator scenarios - Verify method calls are tracked correctly for different configurations
- Consolidated assertion statements for clarity and consistency. - Improved readability by removing unnecessary list comprehensions. - Ensured that test logic remains intact while enhancing code maintainability.
|
|
- Replaced manual tracking of method calls with `unittest.mock.patch` for `xautoclaim` and `xreadgroup`. - Improved test clarity and maintainability by using a spy decorator to verify method calls. - Ensured correct method selection based on `min_idle_time` across various test scenarios.
Lancetnik
reviewed
Dec 9, 2025
| mock.assert_any_call("second_pass_msg0") | ||
|
|
||
| @pytest.mark.slow() | ||
| async def test_min_idle_time_uses_xautoclaim( |
- Removed redundant event initialization within test methods, passing it as a parameter instead. - Improved test structure by consolidating method calls and assertions for clarity. - Verified that XAUTOCLAIM is used correctly based on min_idle_time settings across various scenarios.
Lancetnik
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive tests to verify correct method selection in Redis stream subscribers:
Fixes #2678
Type of change
Please delete options that are not relevant.
Checklist
just lintshows no errors)just test-coveragejust static-analysis