-
Notifications
You must be signed in to change notification settings - Fork 290
Add configurations for subscriber and publisher #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Flosckow
wants to merge
27
commits into
ag2ai:main
Choose a base branch
from
Flosckow:config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
3693f5f
test
Flosckow ea41b9f
drop
Flosckow c0f739f
Add first version, need set queue only in start methods
Flosckow 5937362
remove debug content
Flosckow 62b158a
remove debug file
Flosckow 87e14a0
Try add settign for all params
Flosckow dc1900c
Try resolve all params(include build in factories)
Flosckow 5f536e1
test
Flosckow d53228c
refactor
Flosckow 975c83a
YA refactor
Flosckow ac39be8
Add checking settings
Flosckow 0b47a40
Fix: tests
Flosckow 51f6163
refactor code
Flosckow 1dac0ca
refactor: remove useless logic
Lancetnik 0a72d9a
lint: fix ruff
Lancetnik 7d7d4b6
refactor: move resolve method to parent
Lancetnik 6aa87fa
refactor: change public settings type to dict
Lancetnik e13eb05
refactor: change public settings type to mapping
Lancetnik c0bb0a6
refactor: remove dynamic settings resolution
Lancetnik 29b4f36
refactor: revert changes
Lancetnik 078541f
refactor: revert changes
Lancetnik 3f8a4e4
chore: pull main
Lancetnik fa5be8c
chore: pull main
Lancetnik 7a4cf45
feat: support deep nested settings
Lancetnik 4ec26e1
feat: support mapping resolve
Lancetnik 9933fa5
Need correct last tests
Flosckow 02acbc8
Fix: tests
Flosckow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| from typing import Any | ||
|
|
||
|
|
||
| class Settings: | ||
| def __init__(self, key: str) -> None: | ||
| self.key = key | ||
|
|
||
|
|
||
| class SettingsContainer: | ||
| def __init__(self, **kwargs: Any) -> None: | ||
| self._items = dict(kwargs) | ||
|
|
||
| def resolve_from(self, item: Any) -> Any: | ||
| if isinstance(item, Settings): | ||
| return self._items.get(item.key) | ||
| return item |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.