Skip to content

Conversation

@rsJames-ttrpg
Copy link

@rsJames-ttrpg rsJames-ttrpg commented Aug 12, 2025

Description

Adding the gcppubsub broker via the gcloud-aio library

Closes #1229

Type of change

Please delete options that are not relevant.

  • New feature (a non-breaking change that adds functionality)

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis
  • I have included code examples to illustrate the modifications

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jack Mayo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Aug 12, 2025
@rsJames-ttrpg rsJames-ttrpg marked this pull request as draft August 12, 2025 15:48
@rsJames-ttrpg rsJames-ttrpg changed the title Implement gcp pubsub 3 Implement gcp pubsub broker Aug 12, 2025
@Lancetnik
Copy link
Member

Hi! Looks not so bad. Which LLM model did u use?

@rsJames-ttrpg
Copy link
Author

Hi! Looks not so bad. Which LLM model did u use?

Claude Code, mainly opus, it needs fixing though there are a couple of issues I can see after first human pass.

self,
topic: Annotated[
str,
Doc("Topic name to publish messages to"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on the road to remove all Doc usages. Please, use regular docstrings instead

@Lancetnik Lancetnik mentioned this pull request Aug 26, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCP pubsub support

3 participants