-
Notifications
You must be signed in to change notification settings - Fork 290
Implement gcp pubsub broker #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Jack Mayo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi! Looks not so bad. Which LLM model did u use? |
Claude Code, mainly opus, it needs fixing though there are a couple of issues I can see after first human pass. |
| self, | ||
| topic: Annotated[ | ||
| str, | ||
| Doc("Topic name to publish messages to"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are on the road to remove all Doc usages. Please, use regular docstrings instead
Description
Adding the gcppubsub broker via the gcloud-aio library
Closes #1229
Type of change
Please delete options that are not relevant.
Checklist
just lintshows no errors)just test-coveragejust static-analysis