-
Notifications
You must be signed in to change notification settings - Fork 481
feat: gpt-5 free-form tool calling support #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: gpt-5 free-form tool calling support #2009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I think, we should add a minimal test for final Tool schema generation to validate, that type: custom
indeed
d53438e
to
e26e191
Compare
@Lancetnik updated changes to branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but I am not familiar with tools format enough yet. I am not sure, that it corresponds GPT changes https://cookbook.openai.com/examples/gpt-5/gpt-5_new_params_and_tools
So, I delegate the final decision about merging to other maintainers
@priyansh4320 thanks for this, a few questions:
Some updates:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support a model specific feature with changes in conversable_agent is not a good practice. We need to revisit this implementation.
@randombet I don't see a chance to implement it another way in the current codebase. We need to create a lot of interfaces and our own DTO's to make such things scalable. Until this moment we can just work with raw dictionaries and make the things like this. I suggest to revisit this place in the future as a part of bigger refactoring job. |
Discussed with @priyansh4320 offline and he is onboard. |
Codecov Report❌ Patch coverage is
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Why are these changes needed?
GPT‑5 can now send raw text payloads - anything from Python scripts to SQL queries - to your custom tool without wrapping the data in JSON using the new tool "type": "custom".
Related issue number
closes #2010
Checks