AG-8627 Standardise ZoomManager update flow
#5489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-8627/standardise_updateZoom
branch
3 times, most recently
from
25f2ae3 to
da8f11c
Compare
There are four permutations of ZoomManager updates: 1. `independentAxes: true` / update (both X & Y) 2. `independentAxes: true` / updateAxis (specific AxisID) 3. `independentAxes: false` / update (both X & Y) 4. `independentAxes: false` / updateAxis (specific AxisID) This is very difficult to maintain, because the number of permutations will grow exponentially as we add more options like `independentAxes`. Therefore this commit standardises these permutations into one update flow: 1. Update a list of AxisIDs The permutations are mapped as follows: 1. `independentAxes: true` / update -> AxisIDs = primaryX, primaryY 2. `independentAxes: true` / updateAxis -> AxisIDs = single input axis 3. `independentAxes: false` / update X & Y -> AxisIDs = all axes in internal state 4. `independentAxes: false` / update -> AxisIDs = all axes in direction of input axis
olegat
force-pushed
the
AG-8627/standardise_updateZoom
branch
from
da8f11c to
1767ec5
Compare
Contributor
|
Snapshots automatically updated, please review before merge: |
This is update on manuallyAdjust is redundant (set when `changeType` is 'restoreMemento' or 'reset'), and faulty (it always sets manuallyAdjust to `true` in all update types, such as wheel events on the series-area.
Contributor
|
Snapshots automatically updated, please review before merge: |
Contributor
|
Snapshots automatically updated, please review before merge: |
Contributor
|
Snapshots automatically updated, please review before merge: |
Contributor
|
Snapshots automatically updated, please review before merge: |
olegat
force-pushed
the
AG-8627/standardise_updateZoom
branch
from
73e3730 to
b8de35f
Compare
Contributor
|
Snapshots automatically updated, please review before merge: |
Code in `zoom.ts` should not call `zoomManager.updateChange` directly, it should be routed through `Zoom.updateZoom` in which internally calls `constrainZoom`.
Contributor
|
Snapshots automatically updated, please review before merge: |
There's still some work required in zoom.ts to fully standardise how we perform zoom updates. `constrainZoom` needs to be refactor to operate on "changes" instead of "current `DefinedZoomState`".
olegat
commented
Nov 5, 2025
Contributor
Author
There was a problem hiding this comment.
Important
The changes in this file are difficult to follow. See PR description for summary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-8627
Important
All update branches now lead to
ZoomManager.applyUpdateChangesThere were four permutations of ZoomManager updates:
independentAxes: true/update(both X & Y)independentAxes: true/updateAxis(specific AxisID)independentAxes: false/update(both X & Y)independentAxes: false/updateAxis(specific AxisID)This is very difficult to maintain, because the number of permutations will grow
exponentially as we add more options like
independentAxes. Therefore thiscommit standardises these permutations into one update flow:
The permutations are mapped as follows:
independentAxes: true/update-> AxisIDs = primaryX, primaryYindependentAxes: true/updateAxis-> AxisIDs = single input axisindependentAxes: false/update-> AxisIDs = all axes in internal stateindependentAxes: false/updateAxis-> AxisIDs = all axes in direction of input axis