feat(lints): added proper ast-grep rules for checking println and

unwraps

.ignore

@@ -0,0 +1 @@
+mnn-sys/vendor

flake.nix

@@ -158,7 +158,7 @@
               partitionType = "count";
               cargoExtraArgs = "-p mnn-sys";
             });
-          # mnn-lints = sgLib.scan ./.;
+          mnn-lints = sgLib.scan ./.;
           # mnn-asan = let
           #   rustPlatform = pkgs.makeRustPlatform {
           #     cargo = nightlyToolchain;

sgconfig.yml

@@ -1,2 +1,6 @@
 ruleDirs:
-- ./.rules
+- ./tools/sg-lints/lints
+utilDirs:
+- ./tools/sg-lints/utils
+ignores:
+  - mnn-sys/vendor

src/interpreter.rs

@@ -292,7 +292,7 @@ impl Interpreter {
         let path = path.as_ref();
         crate::ensure!(path.exists(), ErrorKind::IOError);
         let path = path.to_str().ok_or_else(|| error!(ErrorKind::AsciiError))?;
-        let c_path = std::ffi::CString::new(path).unwrap();
+        let c_path = std::ffi::CString::new(path).change_context(ErrorKind::AsciiError)?;
         unsafe { mnn_sys::modelPrintIO(c_path.as_ptr()) }
         Ok(())
     }
@@ -384,7 +384,7 @@ impl Interpreter {
         name: impl AsRef<str>,
     ) -> Tensor<RefMut<'s, Device<H>>> {
         let name = name.as_ref();
-        let c_name = std::ffi::CString::new(name).unwrap();
+        let c_name = std::ffi::CString::new(name).change_context(ErrorKind::AsciiError)?;
         let input =
             mnn_sys::Interpreter_getSessionInput(self.inner, session.inner, c_name.as_ptr());
         Tensor::from_ptr(input)
@@ -866,7 +866,7 @@ fn check_whether_sync_actually_works() {
 }
 
 #[test]
-#[ignore = "This test doesn't work in CI"]
+#[ignore = "Fails on CI"]
 fn try_to_drop_interpreter_before_session() {
     let file = Path::new("tests/assets/realesr.mnn")
         .canonicalize()

tools/sg-lints/lints/no-println.yaml

@@ -0,0 +1,22 @@
+id: no-println
+message: Do not use println! use `tracing::info`/`tracing::trace`/`tracing::debug` instead
+severity: warning
+language: Rust
+rule:
+  kind: macro_invocation
+  pattern: println!($$$ITEMS)
+  not:
+    inside: 
+      stopBy: end
+      matches: is-test
+
+fix: tracing::info!($$$ITEMS)
+files:
+  - src/**/*.rs
+  - mnn-sync/src/*.rs
+  - mnn-sys/src/*.rs
+  - mnn-bridge/src/**/*.rs
+ignores:
+  - build.rs
+  - mnn-sys/build.rs
+  - mnn-sys/vendor/**/*.rs

tools/sg-lints/lints/no-unwrap.yml

@@ -0,0 +1,19 @@
+id: no-unwrap
+message: Do not use unwrap
+severity: error
+language: Rust
+rule:
+  pattern: $ITEM.unwrap()
+  not:
+    inside:
+      stopBy: end
+      matches: is-test
+files:
+  - src/**/*.rs
+  - mnn-sync/src/*.rs
+  - mnn-sys/src/*.rs
+  - mnn-bridge/src/**/*.rs
+ignores:
+  - build.rs
+  - mnn-sys/vendor/**/*.rs
+

tools/sg-lints/utils/is-test.yml

@@ -0,0 +1,23 @@
+id: is-test
+language: Rust
+
+rule:
+  all:
+    - kind: function_item
+    - follows:
+        stopBy: 
+          kind: function_item
+        matches: test-token
+
+utils:
+  test-token:
+    kind: attribute_item
+    has:
+      kind: attribute
+      has:
+        any:
+          - pattern: test
+          - pattern: tokio::test
+
+ignores:
+  - mnn-sys/vendor/**/*.rs