feat: register button

[vuyaniShabangu]

Ticket: https://www.notion.so/6e3bb196180b4fd5822d7c7860c10c81?v=fed4071280464ca48bce19c6c6ba9eb6&p=56f12bd2976549859bcfcafd96e94edb&pm=s

Description:adding register button next to login

[pvanheus]

I'm not getting this code - you added a Register button but what does it do? It seems to also go to INTERNAL_LINKS.Login? Should it not go to NEXT_PUBLIC_KEYCLOAK with some redirect logic as per the existing button here: https://github.com/african-pathogen-archive/portal/blob/develop/components/pages/login/PageContent.tsx#L127 ?

(BTW I think that the existing button - and any new button - should have a configurable redirect that should probably be directed back to the /logged-in page)

[vuyaniShabangu]

I'm not getting this code - you added a Register button but what does it do? It seems to also go to INTERNAL_LINKS.Login? Should it not go to NEXT_PUBLIC_KEYCLOAK with some redirect logic as per the existing button here: https://github.com/african-pathogen-archive/portal/blob/develop/components/pages/login/PageContent.tsx#L127 ?

(BTW I think that the existing button - and any new button - should have a configurable redirect that should probably be directed back to the /logged-in page)

I think the conversation around what we're still going to do with the login button was still ongoing.
So currently the login button takes you the the /login route, where a user can log in or request an account.
So I figured register should also go there since they can follow the request an account flow.

Or should I link to the specific key cloak pages?

[pvanheus]

I'm not getting this code - you added a Register button but what does it do? It seems to also go to INTERNAL_LINKS.Login? Should it not go to NEXT_PUBLIC_KEYCLOAK with some redirect logic as per the existing button here: https://github.com/african-pathogen-archive/portal/blob/develop/components/pages/login/PageContent.tsx#L127 ?
(BTW I think that the existing button - and any new button - should have a configurable redirect that should probably be directed back to the /logged-in page)

I think the conversation around what we're still going to do with the login button was still ongoing. So currently the login button takes you the the /login route, where a user can log in or request an account. So I figured register should also go there since they can follow the request an account flow.

Or should I link to the specific key cloak pages?

I think either we need a Login / Register button (perhaps this is preferable) or the Register button should go to a (configurable - but in our case keycloak) URL.