Skip to content
This repository has been archived by the owner on Sep 3, 2023. It is now read-only.

Commit

Permalink
Resolve some lint warnings and remove an unused resource
Browse files Browse the repository at this point in the history
  • Loading branch information
afollestad committed Dec 19, 2018
1 parent e2037e2 commit 9859215
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 43 deletions.
7 changes: 2 additions & 5 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,12 @@

<string name="recordings_empty_text">You have no recordings, yet…</string>

<string name="dark_mode">Dark Mode</string>
<string name="settings">Settings</string>
<string name="support_me">Support Me</string>

<string name="support_me_message"><![CDATA[
<b>MNML</b> was created and is maintained by one person. Donations are <b>much</b>
appreciated and encourage continued support. Please checkout my
<a href="https://play.google.com/store/apps/dev?id=8293213872477886335">other apps</a> and
my <a href="https://github.com/afollestad">open source</a> projects as well!
<b>MNML</b> was created and is maintained by one person. Donations are <b>much</b>
appreciated and encourage continued support.
]]></string>
<string name="thank_you">Thank you very much!</string>
<string name="support_me_failed">Donation Failed</string>
Expand Down
10 changes: 6 additions & 4 deletions app/src/main/res/values/strings_settings.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<resources>
<resources xmlns:tools="http://schemas.android.com/tools">

<!-- UI -->
<string name="setting_category_ui">UI</string>
Expand All @@ -17,7 +17,9 @@
<string name="setting_audio_bitrate_desc">Audio capture will record at %1$s</string>

<string name="setting_framerate">Frame Rate</string>
<string name="setting_framerate_desc">Screen capture will record at %1$d frames per second.</string>
<string name="setting_framerate_desc" tools:ignore="PluralsCandidate">
Screen capture will record at %1$d frames per second.
</string>

<string name="setting_resolution">Resolution</string>
<string name="setting_resolution_desc">Recording resolution set to %1$dx%2$d.</string>
Expand Down Expand Up @@ -49,10 +51,10 @@

<string name="setting_stop_on_screen_off">Stop on Screen Off</string>
<string name="setting_stop_on_screen_off_desc_on">
When your screen is turned off, any active screen recording will stop.
When your screen is turned off, any active screen recording will stop.
</string>
<string name="setting_stop_on_screen_off_desc_off">
When your screen is turned off, nothing special will happen.
When your screen is turned off, nothing special will happen.
</string>

<string name="setting_always_show_notification">Always Show Notification</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ class BackgroundService : Service(), LifecycleOwner {
log("onDestroy()")
shakeListener.stop()
captureEngine.stop()
lifecycle.onDestroy()
super.onDestroy()
}

Expand Down

This file was deleted.

0 comments on commit 9859215

Please sign in to comment.