feat: Add support for ABS v3.4.0 [KO-460] #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abhishekdwivedi3060
commented
Nov 10, 2025
abhishekdwivedi3060
commented
- Added support for ABS v3.4.0
- Added test-cases for TLS backup and restore
abhishekdwivedi3060
requested review from
jwalantmodi05 and
tanmayja
as code owners
abhishekdwivedi3060
force-pushed
the
feature/KO-460-support-abs-3.4.0
branch
from
c522ba8 to
4d88408
Compare
abhishekdwivedi3060
force-pushed
the
feature/KO-460-support-abs-3.4.0
branch
from
7f6d52f to
2629d88
Compare
abhishekdwivedi3060
force-pushed
the
feature/KO-460-support-abs-3.4.0
branch
from
2629d88 to
429de8c
Compare
| Eventually(func() bool { | ||
| return checkBothRevisionsExist(k8sClient, ctx, clusterNamespacedName, versionV1, versionV2) | ||
| }, 5*time.Minute, 10*time.Second).Should(BeTrue()) | ||
| }, 10*time.Minute, 10*time.Second).Should(BeTrue()) |
Contributor
There was a problem hiding this comment.
why increased timeout? and is 10s interval not high for this?
Collaborator
Author
There was a problem hiding this comment.
Because of 8 thread parallel test runs, it takes more than 5 minutes to satisfy this check.
Retry interval is high to reduce the API calls during the wait period
jwalantmodi05
approved these changes
Nov 25, 2025
tanmayja
approved these changes
Nov 25, 2025
| aerospikeCluster := aerospikeClusterMap[fmt.Sprintf("%s-%s", prefix, "test-cluster")].(map[string]interface{}) | ||
|
|
||
| aerospikeCluster["tls"] = map[string]interface{}{ | ||
| "ca-path": "/etc/aerospike/secret/cacerts", |
Contributor
There was a problem hiding this comment.
Check if we have aliases for these strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.